feat(spark): implement Spark bitwise function shiftleft/shiftright/shiftrightunsighed #17013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
54 tasks
Jefffrey
reviewed
Aug 28, 2025
Comment on lines
+147
to
+154
| // Coerce smaller integer types to Int32 | ||
| let coerced_first = match &arg_types[0] { | ||
| DataType::Int8 | DataType::Int16 | DataType::Null => DataType::Int32, | ||
| DataType::UInt8 | DataType::UInt16 => DataType::UInt32, | ||
| _ => arg_types[0].clone(), | ||
| }; | ||
|
|
||
| Ok(vec![coerced_first, DataType::Int32]) |
There was a problem hiding this comment.
Is there an explanation for why we coerce to these specific types?
There was a problem hiding this comment.
I see, so it's to align with Spark (well Java) only having access to Int/Long types; I do feel this coercion logic might already be expressible via the TypeSignature API, have you given that a shot?
Jefffrey
approved these changes
Sep 14, 2025
Comment on lines
+38
to
+45
| /// | ||
| /// # Arguments | ||
| /// * `value` - The array of values to shift. | ||
| /// * `shift` - The array of shift amounts (must be Int32). | ||
| /// | ||
| /// # Returns | ||
| /// A new array with the shifted values. | ||
| /// |
There was a problem hiding this comment.
Suggested change
| /// | |
| /// # Arguments | |
| /// * `value` - The array of values to shift. | |
| /// * `shift` - The array of shift amounts (must be Int32). | |
| /// | |
| /// # Returns | |
| /// A new array with the shifted values. | |
| /// |
Would prefer to minimize verbosity of documentation where possible (applicable for the other similar instances below)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
What changes are included in this PR?
implement shiftleft/shiftright/shiftrightunsighed.
Are these changes tested?
UT
Are there any user-facing changes?
No