-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Draft: Test non exact size batch #17136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…eam_arrow_coalesce
This is the testing PR for non-exact size, FYI @alamb. The upstream code is here: |
Kicking off becnhmarks |
🤖 |
🤖: Benchmark completed Details
|
🤖 |
Thank you @alamb for benchmark, it's worse than the exact batch, it may due to the extra allocation because we reserve for fixed batch_size. I need to investigate it more. |
🤖: Benchmark completed Details
|
Thank you for your contribution. Unfortunately, this pull request is stale because it has been open 60 days with no activity. Please remove the stale label or comment or this will be closed in 7 days. |
Which issue does this PR close?
Testing for:
#17105 (comment)
Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?