-
Notifications
You must be signed in to change notification settings - Fork 1.8k
[branch-49] Update version to 49.0.1 and add changelog #17175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 'prod' as deployment_environment | ||
| ) | ||
| TO 'data/1.parquet'; | ||
| TO 'test_files/scratch/parquet_filter_pushdown/data/1.parquet'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like the test was previously writing data to datafusion/sqllogictest/data/1.parquet and datafusion/sqllogictest/data/2.parquet which are also checked in
This means that when the new files are written (with a new datafusion version string) they are different which failed the "working directory clean" check. Here is an example: https://github.com/apache/datafusion/actions/runs/16942532196/job/48015583433?pr=17175
I changed this test to properly use the scratch location instead
(I will port this to main as well once we release 49.0.1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # bugs if limits are improperly pushed down) | ||
| query I | ||
| COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/limit/t1.csv' | ||
| COPY (values (1), (2), (3), (4), (5)) TO 'test_files/scratch/joins/t1.csv' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test was failing on the branch. Here is an example https://github.com/apache/datafusion/actions/runs/16948253306/job/48035037022?pr=17175
The issue is that it is using the wrong scratch space. This was fixed by @2010YOUY01 on main in
-
(and a check to prevent it from happening again added in Test: Add checks to sqllogictest temporary file creations #17017)
I backported the fix to this PR to get a clean CI run
andygrove
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @alamb
|
Thanks for the approvals @andygrove and @findepi |
* Update to version 49.0.1 * Add changelog for 49.0.1 * Fix sqllogictests * update configs * Update with PR * prettier * Fix slt race condition * Tweak release notes
|
I have also made a PR to bring these changes to main |
Note this targets
branch-49, not mainI plan to regenerate the changelog one more time once the final PRs have been merged
Which issue does this PR close?
49.0.1(patch) #17036Rationale for this change
Prepare for the release
What changes are included in this PR?
49.0.1I generated the changelog like this
./dev/release/generate-changelog.py 49.0.0 branch-49 49.0.1 > dev/changelog/49.0.1.md npx prettier -w dev/changelog/49.0.1.mdAre these changes tested?
By CI
Are there any user-facing changes?
New version/changelog
Note once this PR merges I will forward port it to main