Deprecate confusingly named UserDefinedFunctionPlanner
#17247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
alamb
commented
Aug 19, 2025
| feature = "datetime_expressions", | ||
| feature = "unicode_expressions" | ||
| ))] | ||
| Arc::new(functions::planner::UserDefinedFunctionPlanner), |
There was a problem hiding this comment.
for some reason both datetime and unicode expressions were in the same planner, which is not the same pattern for the other features 🤷 -- so I propose making main follow the existing pattern
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
As I was reviewing #16456 with @Jefffrey and @Dimchikkk, I found a file which contains expression planners for unicode and datetime functions, but is confusingly called
UserDefinedFunctionPlannerWhat changes are included in this PR?
UserDefinedFunctionPlannerinto two structs to follow the pattern in the rest of the moduleUserDefinedFunctionPlannerAre these changes tested?
By CI
Are there any user-facing changes?