-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support WHERE
, ORDER BY
, LIMIT
, SELECT
, EXTEND
pipe operators
#17278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
😮 amazing Can we please add some more examples / overview of the new syntax to the user guide: |
I have updated the user-guide. |
I noticed in apache#17278 that `from` without an explicit projection did not work. This should fix it
* Support from-first syntax I noticed in #17278 that `from` without an explicit projection did not work. This should fix it * add more tests * document in user guide
3b0892b
to
1e0b8db
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not as familiar with the sql codebase but if tests pass then seems fine 👍
Just a few minor comments otherwise.
Thank you for the review @Jefffrey! I have pushed commits addressing each comment separately |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
CI failure is unrelated to this PR, been seeing it across other PRs & on main |
Which issue does this PR close?
Part of #14660
Rationale for this change
sqlparser 0.58 released with support for parsing pipe operators.
Let's see if we can make Datafusion support executing them.
What changes are included in this PR?
Support for the following pipe operators
These were the ones I could manage in an evening, so I decided to flush this PR as-is.
Are these changes tested?
I added an SLT test for each operator. Please let me know if you want any other cases tested.
Are there any user-facing changes?
Yes, if the dialect is set to one that supports pipe operators, those can then be executed.