Skip to content

Conversation

@lewiszlw
Copy link
Member

@lewiszlw lewiszlw commented Aug 22, 2025

Which issue does this PR close?

Rationale for this change

Memory datasource exec could be serialized for distributed execution.

What changes are included in this PR?

Support serializing / deserializing memory datasource in proto.

Are these changes tested?

Added unit test.

Are there any user-facing changes?

No.

@github-actions github-actions bot added the proto Related to proto crate label Aug 22, 2025
@lewiszlw lewiszlw marked this pull request as draft August 22, 2025 14:35
@lewiszlw lewiszlw marked this pull request as ready for review August 25, 2025 02:39
Copy link
Member

@timsaucer timsaucer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very reasonable, but I have the one question about the submodule.

@lewiszlw lewiszlw merged commit 6fd5685 into apache:main Sep 5, 2025
28 checks passed
destrex271 pushed a commit to destrex271/datafusion that referenced this pull request Sep 5, 2025
* Add proto

* fix proto

* gen proto code

* exec to proto

* gen proto code

* impl (de)serialization

* Add test

* Update submodules

* gen proto

* Set parquet-testing back to main

---------

Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Co-authored-by: Tim Saucer <timsaucer@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support MemoryExec in proto try_from_physical_plan

3 participants