-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Support JOIN
, PIVOT
pipe operators
#17365
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
443fdc1
to
dc60f73
Compare
dc60f73
to
b584074
Compare
Merged up from main, ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we split this PR to only be for JOIN, and do PIVOT in a separate PR where it can hopefully use pivot from the logical plan builder if/when it gets merged?
Good idea, created #17969 |
Which issue does this PR close?
Part of #14660
Rationale for this change
Draft until #17946 is merged. Then we can use the LogicalPlanBuilder
sqlparser 0.58 released with support for parsing pipe operators.
Let's see if we can make Datafusion support executing them.
What changes are included in this PR?
Support for the following pipe operators
I did not find any support for the pivot operation in Datafusion, so I added an initial implementation. This code could probably be used in a later PR to fix #12907
Are these changes tested?
Yes, I have added SLT tests
Are there any user-facing changes?
Yes, if the dialect is set to one that supports pipe operators, those can then be executed.