Skip to content

Conversation

@findepi
Copy link
Member

@findepi findepi commented Sep 4, 2025

We sometimes add MSRV changes to upgrade guides. We should consistently either do it always, or not at all.
Let's add the recent change.

@findepi findepi requested review from adriangb and alamb September 4, 2025 11:49
@github-actions github-actions bot added the documentation Improvements or additions to documentation label Sep 4, 2025
Copy link
Contributor

@adriangb adriangb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

Copy link
Contributor

@comphead comphead left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @findepi the next good step would be update upgrading.md to reflect MSRV changes might be included

@adriangb
Copy link
Contributor

adriangb commented Sep 4, 2025

Thanks @findepi the next good step would be update upgrading.md to reflect MSRV changes might be included

Do you mean like a meta section ## What you might find in upgrading.md?

@adriangb
Copy link
Contributor

adriangb commented Sep 4, 2025

(I'm going to merge this and leave any general improvements other than upgrading.md itself for another PR)

@adriangb adriangb merged commit cb69574 into apache:main Sep 4, 2025
5 checks passed
@comphead
Copy link
Contributor

comphead commented Sep 4, 2025

Thanks @findepi the next good step would be update upgrading.md to reflect MSRV changes might be included

Do you mean like a meta section ## What you might find in upgrading.md?

Probably https://datafusion.apache.org/contributor-guide/api-health.html#upgrade-guides here would be the better place, saying not only code changes are included but also project level changes like MSRV

@findepi findepi deleted the findepi/add-msrv-change-to-upgrade-guide-abb984 branch September 4, 2025 16:52
destrex271 pushed a commit to destrex271/datafusion that referenced this pull request Sep 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants