Skip to content

Conversation

@zhuqi-lucas
Copy link
Contributor

Which issue does this PR close?

Support csv truncated rows in datafusion

Rationale for this change

Support csv truncated rows in datafusion

What changes are included in this PR?

Support csv truncated rows in datafusion

Are these changes tested?

Yes

Are there any user-facing changes?

New feature support.

@github-actions github-actions bot added core Core DataFusion crate common Related to common crate proto Related to proto crate datasource Changes to the datasource crate labels Sep 7, 2025
Copy link
Member

@xudong963 xudong963 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb
Copy link
Contributor

alamb commented Sep 8, 2025

Thanks @zhuqi-lucas !

@zhuqi-lucas
Copy link
Contributor Author

Thank you @xudong963 , @alamb!

@zhuqi-lucas zhuqi-lucas merged commit 7b16d6b into apache:main Sep 9, 2025
28 checks passed
zhuqi-lucas added a commit to massive-com/arrow-datafusion that referenced this pull request Sep 16, 2025
@sm4rtm4art
Copy link
Contributor

sm4rtm4art commented Nov 11, 2025

Hey,

I'm currently updating the DataFrame API documentation and noticed something about CsvReadOptions.

The method truncated_rows is publicly available in the source, but it doesn't seem to be rendered on the docs.rs page here:
https://docs.rs/datafusion/latest/datafusion/datasource/file_format/options/struct.CsvReadOptions.html

although it is implemented here :

https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/file_format/options.rs#L94-L98

I just wanted to confirm if this is expected before I document it.

It seems like a useful builder method to mention.

Thanks!

@zhuqi-lucas
Copy link
Contributor Author

Hey,

I'm currently updating the DataFrame API documentation and noticed something about CsvReadOptions.

The method with_truncated_rows is publicly available in the source, but it doesn't seem to be rendered on the docs.rs page here: https://docs.rs/datafusion/latest/datafusion/datasource/file_format/options/struct.CsvReadOptions.html

although it is implemented here :

https://github.com/apache/datafusion/blob/main/datafusion/core/src/datasource/file_format/options.rs#L94-L98

I just wanted to confirm if this is expected before I document it.

It seems like a useful builder method to mention.

Thanks!

It works well @sm4rtm4art , thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

common Related to common crate core Core DataFusion crate datasource Changes to the datasource crate proto Related to proto crate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support csv truncated rows in datafusion

4 participants