feat: Add binary to join_fuzz testing
#17497
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@stuartcarnie @alamb I was doing this pull request and realized that the current join fuzz testing currently only supports i32. I could make a follow up to use a macro to create tests for each type but I would need to take a look at how long the tests are taking. What do you think a good threshold would be for testing time? |
Member
|
@jonathanc-n maybe we don't need each type? i would focus on int64, decimal and Utf8(View), since these are likely most common join keys. |
findepi
approved these changes
Sep 10, 2025
Contributor
|
Thank you @jonathanc-n and @findepi I agree it might be worth figuring out some way to expand coverage that doesn't require so many individual tests to be added / updated 🤔 |
samueleresca
pushed a commit
to samueleresca/datafusion
that referenced
this pull request
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Fuzz testing did not contain binary types.
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?