Fix docs.rs build: Replace auto_doc_cfg with doc_cfg
#17845
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
sql
18 tasks
22 tasks
alamb
approved these changes
Sep 30, 2025
There was a problem hiding this comment.
THank you @mbrobbel
Specifically, without this PR the docs.rs build is failing
You can see it like
rustup update
cargo +nightly docs-rs -p datafusionerror[E0557]: feature has been removed
--> datafusion/core/src/lib.rs:22:29
|
22 | #![cfg_attr(docsrs, feature(doc_auto_cfg))]
| ^^^^^^^^^^^^ feature has been removed
|
= note: removed in CURRENT_RUSTC_VERSION; see <https://github.com/rust-lang/rust/pull/138907> for more information
= note: merged into `doc_cfg`
error: Compilation failed, aborting rustdoc
For more information about this error, try `rustc --explain E0557`.
error: could not document `datafusion`
With this PR it builds successfully!
alamb
changed the title
auto_doc_cfg with doc_cfgauto_doc_cfg with doc_cfg
xudong963
approved these changes
Oct 1, 2025
AdamGS
pushed a commit
to AdamGS/arrow-datafusion
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
None
Rationale for this change
auto_doc_cfgwas merged intodoc_cfgin rust-lang/rust#138907 so without this change the docs.rs build fails.What changes are included in this PR?
Use
doc_cfginstead ofauto_doc_cfg.Are these changes tested?
Tested with https://github.com/dtolnay/cargo-docs-rs
Are there any user-facing changes?
No