[Branch-50] Backport: Support Decimal32/64 types (#17501) #17907
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGS
changed the title
github-actions
bot
added
sql
This was referenced Oct 3, 2025
|
Why does this PR has substantially more lines that the original PR? This PR Original PR: #17501 
|
|
there are changes in |
* Support Decimal32/64 types * Fix bugs, tests, handle more aggregate functions and schema * Fill out more parts in expr,common and expr-common * Some stragglers and overlooked corners * Actually commit the avg_distinct support --------- Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
AdamGS
force-pushed
the
adamg/backport-17501
branch
from
3bb79ae to
d8b844d
Compare
|
Ok now it seems better, its not a perfect match because some of the changes were based upon #17459, which wasn't backported. |
alamb
reviewed
Oct 3, 2025
| /// 64bit float | ||
| Float64(Option<f64>), | ||
| /// 32bit decimal, using the i32 to represent the decimal, precision scale | ||
| Decimal32(Option<i32>, u8, i8), |
There was a problem hiding this comment.
I think 🤔 this is technically a breaking API change I think because ScalarValue is a public enum and not parsed non_exhastive... So we can't backport it to the branch-50 without breaking the API
There was a problem hiding this comment.
That makes perfect sense, should've noticed it myself.
I can wait until November, sorry about causing so much noise pushing for this release, at least we'll get the docs fix in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
50.2.0(minor) #17849Rationale for this change
Backports initial support for decimal 32/64 to the 50.x branch
What changes are included in this PR?
See original PR:
Are these changes tested?
Includes some tests and reinforced by SLT. Follow up PR contains more tests.
Are there any user-facing changes?
No