clean up duplicate information in FileOpener trait #17956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
core
adriangb
force-pushed
the
clean-up-apis
branch
from
d649a43 to
d5a0cd9
Compare
adriangb
force-pushed
the
clean-up-apis
branch
from
d5a0cd9 to
3a5216a
Compare
xudong963
approved these changes
Oct 8, 2025
|
Do you think it's worth adding this to the upgrade guide? I think it's quite straightforward and will impact few people. So maybe not worth the noise? |
comphead
reviewed
Oct 8, 2025
| &self, | ||
| _partition_index: usize, | ||
| file_meta: FileMeta, | ||
| file: PartitionedFile, |
There was a problem hiding this comment.
1 nit: we probably can name it as partition_file to be the same format as other function params
comphead
reviewed
Oct 8, 2025
| file_meta: FileMeta, | ||
| _file: PartitionedFile, | ||
| ) -> Result<FileOpenFuture> { | ||
| fn open(&self, file: PartitionedFile) -> Result<FileOpenFuture> { |
comphead
reviewed
Oct 8, 2025
| &self, | ||
| partition_index: usize, | ||
| file_meta: FileMeta, | ||
| file: PartitionedFile, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ever since #16014 we've been passing duplicate information in.
FileMetais created entirely fromPartitionedFile. This simplifies APIs and removes an unnecessary struct.