Run extended tests when there are changes to datafusion-testing pin #18310
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 27, 2025
alamb
changed the title
|
lgtm |
|
Thanks for the review @Omega359 |
Jefffrey
approved these changes
Oct 30, 2025
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…pache#18310) ## Which issue does this PR close? ## Rationale for this change The `extended` tests rely on the checkout of datafusion-testing (that has the expected results for the sqlite sqllogictest suite) However, we don't currently run the extended tests when that pin is changed so we could potentially break CI on main if we don't catch changes in code review (this just happened to me in apache#17866 (review)) ## What changes are included in this PR? 1. Run extended CI tests on changes to datafusion-testing ## Are these changes tested? I tested this in PR - apache#18311 - apache#18312 ## Are there any user-facing changes? No
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
The
extendedtests rely on the checkout of datafusion-testing (that has the expected results for the sqlite sqllogictest suite)However, we don't currently run the extended tests when that pin is changed so we could potentially break CI on main if we don't catch changes in code review (this just happened to me in #17866 (review))
What changes are included in this PR?
Are these changes tested?
I tested this in PR
datafusion-testingbackwards w/ new CI check #18311datafusion-testingbackwards #18312Are there any user-facing changes?
No