Fix: spark bit_count function #18322
Open
+49
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| // Here’s the equivalent Rust implementation of the bitCount function (similar to Apache Spark's bitCount for LongType) | ||
| fn bit_count(i: i64) -> i32 { |
There was a problem hiding this comment.
Could we enhance the comment here with this link + potentially link to original source code this actual function is copied from?
There was a problem hiding this comment.
Thanks, added
| let value_array = value_array[0].as_ref(); | ||
| match value_array.data_type() { | ||
| DataType::Int8 => { | ||
| DataType::Int8 | DataType::Boolean => { |
There was a problem hiding this comment.
Spark supports only signed int types
There was a problem hiding this comment.
This comment seems misplaced as the code adds support for boolean 🤔
There was a problem hiding this comment.
I also think this code will now panic if you pass in a Boolean array
There was a problem hiding this comment.
I wanted to note that Spark only supports signed integer and boolean types as input.
There was a problem hiding this comment.
Added an additional test for BooleanArray.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #18225
Rationale for this change
After adding the bit_count function in Comet, we got different results from Spark. (apache/datafusion-comet#2553)
Are these changes tested?
Tested with existing unit tests