Skip to content

catch errors when simplifying cast(lit(...), ...) and bubble those up #18332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 31, 2025
Merged

catch errors when simplifying cast(lit(...), ...) and bubble those up #18332

merged 3 commits into from
Oct 31, 2025
+81 −20

Conversation

@adriangb
Copy link
Contributor

@adriangb adriangb commented Oct 28, 2025 •
edited by alamb
Loading

@github-actions github-actions bot added the optimizer Optimizer rules label Oct 28, 2025
@Omega359
Copy link
Contributor

sqllogictests will need to be updated.

4. query is expected to fail with error:
	(regex) DataFusion error: Arrow error: Cast error: Cannot cast string 'a' to value of Int64 type
but got error:
	DataFusion error: Optimizer rule 'simplify_expressions' failed
caused by
Arrow error: Cast error: Cannot cast string 'a' to value of Int64 type
[SQL] SELECT map_keys(MAP { 'a': 1, 2: 3 });
at /__w/datafusion/datafusion/datafusion/sqllogictest/test_files/map.slt:712

@github-actions github-actions bot added the sqllogictest SQL Logic Tests (.slt) label Oct 30, 2025
@adriangb
Copy link
Contributor Author

thanks @Omega359 should be updated now!

@Omega359
Copy link
Contributor

LGTM

alamb
alamb approved these changes Oct 31, 2025
View reviewed changes
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @adriangb and @Omega359

@adriangb adriangb added this pull request to the merge queue Oct 31, 2025
Merged via the queue into apache:main with commit 70e9155 Oct 31, 2025
33 checks passed
@adriangb adriangb deleted the cast-logical branch October 31, 2025 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alamb alamb alamb approved these changes

Assignees

No one assigned

Labels

optimizer Optimizer rules sqllogictest SQL Logic Tests (.slt)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Optimize casts at the logical layer

3 participants

@adriangb @Omega359 @alamb