minor: Fix parquet pruning metrics display order #18379
Conversation
github-actions
bot
added
core
| Self::PruningMetrics { name, .. } => match name.as_ref() { | ||
| // The order is the same as the actual pruning order: from | ||
| // coarse-grained to fine-grained pruning levels. | ||
| "files_ranges_pruned_statistics" => 3, |
There was a problem hiding this comment.
It's a little bit hacky 🤔 but I think this way is simpler and easy to update.
There was a problem hiding this comment.
maybe a comment could help / ticket to assist others who find this code and are confused by it
There was a problem hiding this comment.
Good idea, comments added.
There was a problem hiding this comment.
Thanks @2010YOUY01
just 1 thing, if the name is changed for example from files_ranges_pruned_statistics to files_ranges_pruned_statistics_other in project but not in value.rs will the test detect it and fail?
Yes, the UT in this PR will catch such changes. |
There was a problem hiding this comment.
Thanks @2010YOUY01 -- the metrics just keep getting better!
| Self::PruningMetrics { name, .. } => match name.as_ref() { | ||
| // The order is the same as the actual pruning order: from | ||
| // coarse-grained to fine-grained pruning levels. | ||
| "files_ranges_pruned_statistics" => 3, |
There was a problem hiding this comment.
maybe a comment could help / ticket to assist others who find this code and are confused by it
|
Thank you both for the review! |
3 participants
Which issue does this PR close?
Rationale for this change
It's better to let pruning metrics in parquet displayed in an order that is the same as the actual pruning order:
Now it's ordered alphabetically.
See #18321 (comment) for reproducing.
What changes are included in this PR?
Update the sort key API in
MetricValue, to let the parquet pruning metrics display in the expected order.Are these changes tested?
UT
Are there any user-facing changes?
No