Add benchmarks section to DEVELOPERS.md #1838
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
datafusion
tustvold
commented
Feb 15, 2022
| @@ -229,7 +229,7 @@ fn criterion_benchmark(c: &mut Criterion) { | |||
| }); | |||
| } | |||
|
|
|||
| // Clean up temporary file if any | |||
| // Temporary file must outlive the benchmarks, it is deleted when dropped | |||
There was a problem hiding this comment.
This was review feedback from #1738 (comment)
There was a problem hiding this comment.
sorry I needed the dopamine hit of clicking the green button -- I should have waited
alamb
approved these changes
Feb 15, 2022
| cargo bench --bench parquet_query_sql | ||
| ``` | ||
|
|
||
| These randomly generate a parquet file, and then benchmark queries sourced from [parquet_query_sql.sql](./datafusion/benches/parquet_query_sql.sql) against it. This can therefore be a quick way to add coverage of particular query and/or data paths. |
| @@ -229,7 +229,7 @@ fn criterion_benchmark(c: &mut Criterion) { | |||
| }); | |||
| } | |||
|
|
|||
| // Clean up temporary file if any | |||
| // Temporary file must outlive the benchmarks, it is deleted when dropped | |||
There was a problem hiding this comment.
sorry I needed the dopamine hit of clicking the green button -- I should have waited
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rationale for this change
This was requested on #1738 (comment)
What changes are included in this PR?
Adds some documentation on how to run the criterion benchmarks
Are there any user-facing changes?
No code changes