Extract out super slow planning benchmark to it's own benchmark #18388
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Oct 30, 2025
There was a problem hiding this comment.
Thanks @Omega359 -- this is clearly an improvement over main
THere are some others like
Benchmarking physical_sorted_union_order_by_200: Warming up for 3.0000 s
Warning: Unable to complete 100 samples in 5.0s. You may wish to increase target time to 557.0s, or reduce sample count to 10.
Benchmarking physical_sorted_union_order_by_200: Collecting 100 samples in estimated 556.98 s (100 iterations)
That still take time but that is only 10 minutes (not hours!)
| use std::sync::Arc; | ||
| use tokio::runtime::Runtime; | ||
|
|
||
| /// Registers a table like this: |
There was a problem hiding this comment.
Maybe we could add some context to this benchmark that explains the reproducer is very slow and designed to cover certain planning cases, referencing
…nted out 100 && 200 columns in physical_sorted_union_order_by_ benchmarks.
tobixdev
pushed a commit
to tobixdev/datafusion
that referenced
this pull request
Nov 2, 2025
…he#18388) ## Which issue does this PR close? - Closes apache#18366 ## Rationale for this change Speed up the running of sql planner benchmarks ## What changes are included in this PR? Extracted out the 'logical_plan_optimize' benchmark to its own file. ## Are these changes tested? Yes. ## Are there any user-facing changes? No.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
Speed up the running of sql planner benchmarks
What changes are included in this PR?
Extracted out the 'logical_plan_optimize' benchmark to its own file.
Are these changes tested?
Yes.
Are there any user-facing changes?
No.