-
Notifications
You must be signed in to change notification settings - Fork 1.9k
feat: support spark csc #18642
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
feat: support spark csc #18642
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Nov 12, 2025
martin-g
reviewed
Nov 12, 2025
psvri
commented
Nov 13, 2025
Jefffrey
approved these changes
Nov 14, 2025
martin-g
approved these changes
Nov 14, 2025
Contributor
jizezhang
pushed a commit
to jizezhang/datafusion
that referenced
this pull request
Nov 15, 2025
## Which issue does this PR close? Partially implements apache#15914 ## Rationale for this change Spark has support for cosecant https://spark.apache.org/docs/latest/api/sql/index.html#csc . This function is not there othere in DB's like postgres, mysql and sqlite3. Hence I have added this function into datafusion-spark ## What changes are included in this PR? Adds support for cosecant in datafusion-spark ## Are these changes tested? Unit tests with inputs/outputs obtained from spark ## Are there any user-facing changes? Yes
logan-keede
pushed a commit
to logan-keede/datafusion
that referenced
this pull request
Nov 23, 2025
## Which issue does this PR close? Partially implements apache#15914 ## Rationale for this change Spark has support for cosecant https://spark.apache.org/docs/latest/api/sql/index.html#csc . This function is not there othere in DB's like postgres, mysql and sqlite3. Hence I have added this function into datafusion-spark ## What changes are included in this PR? Adds support for cosecant in datafusion-spark ## Are these changes tested? Unit tests with inputs/outputs obtained from spark ## Are there any user-facing changes? Yes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Partially implements #15914
Rationale for this change
Spark has support for cosecant https://spark.apache.org/docs/latest/api/sql/index.html#csc .
This function is not there othere in DB's like postgres, mysql and sqlite3. Hence I have added this function into datafusion-spark
What changes are included in this PR?
Adds support for cosecant in datafusion-spark
Are these changes tested?
Unit tests with inputs/outputs obtained from spark
Are there any user-facing changes?
Yes