minor: refactor with assert_or_internal_err!() in datafusion/functions
#18700
+42
−31
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jefffrey
reviewed
Nov 14, 2025
Comment on lines
116
to
119
| assert_or_internal_err!( | ||
| lhs.len() == rhs.len(), | ||
| "All arrays should have the same length for greatest comparison" | ||
| ); |
Contributor
There was a problem hiding this comment.
Should be using assert_eq_or_internal_err?
Contributor
Author
There was a problem hiding this comment.
Yes, you are right I should have done that.
14 tasks
Jefffrey
reviewed
Nov 14, 2025
| ); | ||
| } | ||
| assert_or_internal_err!( | ||
| lhs.len() == rhs.len(), |
Jefffrey
approved these changes
Nov 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
assert_or_internal_err!()across the codebase #18613Rationale for this change
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?