[split/17] move the rest of physical expr to datafusion-physical-expr crate #1892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimexist
changed the title
34 tasks
jimexist
force-pushed
the
move-more-physical-expr
branch
4 times, most recently
from
592f74a
to
2e6ea19
Compare
jimexist
requested review from
alamb and
houqp
and removed request for
alamb
jimexist
force-pushed
the
move-more-physical-expr
branch
from
2e6ea19
to
6b9fc64
Compare
jimexist
force-pushed
the
move-more-physical-expr
branch
from
6b9fc64
to
e4d6261
Compare
alamb
approved these changes
Feb 28, 2022
| unicode_expressions = ["unicode-segmentation"] | ||
| crypto_expressions = [ "datafusion-physical-expr/crypto_expressions" ] | ||
| unicode_expressions = ["datafusion-physical-expr/regex_expressions"] | ||
| regex_expressions = ["datafusion-physical-expr/regex_expressions"] |
| is_avg_support_arg_type, is_correlation_support_arg_type, | ||
| is_covariance_support_arg_type, is_stddev_support_arg_type, is_sum_support_arg_type, | ||
| is_variance_support_arg_type, try_cast, | ||
| pub use datafusion_physical_expr::coercion_rule::aggregate_rule::{ |
There was a problem hiding this comment.
yeah as a follow on we can maybe consolidate a bit more. This is good for now 👍
|
Thanks @jimexist ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
move the rest of physical expr to datafusion-physical-expr crate
What changes are included in this PR?
Are there any user-facing changes?