Skip to content

fix: inverted null_percent logic in in_list benchmark #19204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adriangb merged 1 commit into from
Dec 8, 2025
Merged

fix: inverted null_percent logic in in_list benchmark #19204

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions datafusion/physical-expr/benches/in_list.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,10 +49,12 @@ fn do_benches(
null_percent: f64,
) {
let mut rng = StdRng::seed_from_u64(120320);
let non_null_percent = 1.0 - null_percent;

for string_length in [5, 10, 20] {
let values: StringArray = (0..array_length)
.map(|_| {
rng.random_bool(null_percent)
rng.random_bool(non_null_percent)
.then(|| random_string(&mut rng, string_length))
})
.collect();
Expand All @@ -72,7 +74,7 @@ fn do_benches(
}

let values: Float32Array = (0..array_length)
.map(|_| rng.random_bool(null_percent).then(|| rng.random()))
.map(|_| rng.random_bool(non_null_percent).then(|| rng.random()))
.collect();

let in_list: Vec<_> = (0..in_list_length)
Expand All @@ -87,7 +89,7 @@ fn do_benches(
);

let values: Int32Array = (0..array_length)
.map(|_| rng.random_bool(null_percent).then(|| rng.random()))
.map(|_| rng.random_bool(non_null_percent).then(|| rng.random()))
.collect();

let in_list: Vec<_> = (0..in_list_length)
Expand Down