Skip to content

Use correct setting for click bench queries in sql_planner benchmark #19835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alamb merged 1 commit into from
Jan 15, 2026
Merged

Use correct setting for click bench queries in sql_planner benchmark #19835

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions datafusion/core/benches/sql_planner.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,6 +118,11 @@ fn register_clickbench_hits_table(rt: &Runtime) -> SessionContext {

let sql = format!("CREATE EXTERNAL TABLE hits STORED AS PARQUET LOCATION '{path}'");

// ClickBench partitioned dataset was written by an ancient version of pyarrow that
// that wrote strings with the wrong logical type. To read it correctly, we must
// automatically convert binary to string.
rt.block_on(ctx.sql("SET datafusion.execution.parquet.binary_as_string = true;"))
.unwrap();
rt.block_on(ctx.sql(&sql)).unwrap();

let count =
Expand Down