Fix incorrect SortExec removal before AggregateExec (option 2)
#20247
+258
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
optimizer
This was referenced Feb 9, 2026
alamb
changed the title
SortExec removal before AggregateExec (option 2)
alamb
force-pushed
the
alamb/fix_monotonic_sort_bug_option2
branch
from
33cc3f2 to
3d6b8cd
Compare
alamb
commented
Feb 10, 2026
| } | ||
| } | ||
| } else if let Some(aggregate_exec) = plan.as_any().downcast_ref::<AggregateExec>() { | ||
| handle_aggregate_pushdown(aggregate_exec, parent_required) |
Contributor
Author
There was a problem hiding this comment.
This comment explains why this is needed: #19287 (comment)
Basically the generic version is not correct for AggregateExec, but this was masked due to some limitations that were lifted in #19287
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
This is an alternatative to
SortExecremoval beforeAggregateExec#20245Rationale for this change
Wrong answers bug was exposed by #19287 in 52. See #20244 and backstory here
What changes are included in this PR?
Fix the bug by properly implemnting
Are these changes tested?
Yes, a new test is added
Are there any user-facing changes?
A bug is fixed