perf: Optimize scalar fast path for regexp_like#20354
Open
kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Open
perf: Optimize scalar fast path for regexp_like#20354kumarUjjawal wants to merge 2 commits intoapache:mainfrom
regexp_like#20354kumarUjjawal wants to merge 2 commits intoapache:mainfrom
Conversation
Jefffrey
reviewed
Feb 14, 2026
| ColumnarValue::Array(a) => Some(a.len()), | ||
| }); | ||
|
|
||
| let is_scalar = len.is_none(); |
Contributor
There was a problem hiding this comment.
We should take the chance here to do further refactors; for example we can use ColumnarValue::values_to_arrays here
| .iter() | ||
| .all(|arg| matches!(arg, ColumnarValue::Scalar(_))); | ||
|
|
||
| if is_scalar { |
Contributor
There was a problem hiding this comment.
I think we should think in terms of how people may use this function; while this is a fast path for pure scalar inputs, it could be likely that users would have the first argument as an array but the 2nd/3rd arguments as scalar inputs, so would be worth considering a fast path for that too?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
regexp_likewas converting scalar inputs into single‑element arrays, adding avoidable overhead for constant folding and scalar‑only evaluations.What changes are included in this PR?
Are these changes tested?
Yes
Are there any user-facing changes?
NO