Disable dynamic filter pushdown to parquet by default#20365
Draft
Dandandan wants to merge 11 commits intoapache:mainfrom
Draft
Disable dynamic filter pushdown to parquet by default#20365Dandandan wants to merge 11 commits intoapache:mainfrom
Dandandan wants to merge 11 commits intoapache:mainfrom
Conversation
Contributor
Author
|
run benchmark tpch tpcds |
Contributor
Author
|
run benchmark clickbench_partitioned |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Rationale for this change
We have seen the evaluation cost leads to slowdowns when enabling parquet pushdown.
In order to enable filter pushdown be default without introducing large regressions, we can disable the dynamic filters during file scans (but keep them for pruning).
What changes are included in this PR?
Are these changes tested?
Are there any user-facing changes?