feat: Support simple Arrays with Literals #2194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ovr
force-pushed
the
scalar-arrays
branch
3 times, most recently
from
4300ee9 to
2e173b6
Compare
alamb
approved these changes
Apr 12, 2022
There was a problem hiding this comment.
Thanks @ovr -- looks good!
It's first iteration, I will send later another PR with implementing the new expression node which can holds expressions and optimizer to simplify it.
I think this sounds like a good implementation plan
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
Dandandan
approved these changes
Apr 13, 2022
|
Thank you @ovr ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #2207
Hello!
This PR introduces support for simple arrays with literal. For example it can support
[1,2,3]or nested:[[1,2], [3,4]], but it doesn't support array with expressions for example: [now()].It's first iteration, I will send later another PR with implementing the new expression node which can holds expressions and optimizer to simplify it.
Thanks