Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add sql level test for decimal data type #2200

Merged
merged 5 commits into from
Apr 14, 2022
Merged

add sql level test for decimal data type #2200

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39293c2
add sql level test for decimal data type
liukun4515 Apr 11, 2022
39848f9
Merge remote-tracking branch 'upstream/master' into decimal_test_in_s…
liukun4515 Apr 12, 2022
4e0ac61
add decimal test
liukun4515 Apr 13, 2022
c6af4ee
add license for new file
liukun4515 Apr 13, 2022
7925799
address comments
liukun4515 Apr 14, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions datafusion/core/src/physical_plan/aggregate_rule.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,8 +65,7 @@ mod tests {
];
let input_types = vec![
vec![DataType::Int32],
// support the decimal data type for min/max agg
// vec![DataType::Decimal(10, 2)],
vec![DataType::Decimal(10, 2)],
vec![DataType::Utf8],
];
for fun in funs {
Expand Down
16 changes: 16 additions & 0 deletions datafusion/core/tests/decimal_data.csv
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
c1,c2,c3,c4,c5
0.00001,0.000000000001,1,true,0.000014
0.00002,0.000000000002,2,true,0.000025
0.00002,0.000000000002,3,false,0.000019
0.00003,0.000000000003,4,true,0.000032
0.00003,0.000000000003,5,false,0.000035
0.00003,0.000000000003,5,true,0.000011
0.00004,0.000000000004,5,true,0.000044
0.00004,0.000000000004,12,false,0.000040
0.00004,0.000000000004,14,true,0.000040
0.00004,0.000000000004,8,false,0.000044
0.00005,0.000000000005,9,true,0.000052
0.00005,0.000000000005,4,true,0.000078
0.00005,0.000000000005,8,false,0.000033
0.00005,0.000000000005,100,true,0.000068
0.00005,0.000000000005,1,false,0.000100
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😂 I often find there's not new line for PR because of neglection.

I think I can add a editor config for this.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#2224

Loading