-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add single line description of ExecutionPlan (#2216) #2217
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
approved these changes
Apr 13, 2022
Looks useful to me 👍 |
alamb
reviewed
Apr 13, 2022
Co-authored-by: Andrew Lamb <andrew@nerdnetworks.org>
tustvold
commented
Apr 13, 2022
Another physical plan description optimization would be to limit each physical plan's max line width. This would be especially useful for the ParquetExec node:
It would be wonderful if I could reduce this to:
Actually, I was thinking of this when I first saw the title. |
Perhaps #2079 might help with that 😅 |
yjshen
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2216
Rationale for this change
See ticket
What changes are included in this PR?
Adds the ability to get a single-line summary of the root of an ExecutionPlan
Are there any user-facing changes?
No