Add type coercion rule for date + interval #2235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andy Grove <agrove@apache.org>
Dandandan
approved these changes
Apr 14, 2022
yjshen
approved these changes
Apr 15, 2022
liukun4515
approved these changes
Apr 15, 2022
|
the rule of type-coercion should be extracted if there are too many |
alamb
reviewed
Apr 15, 2022
There was a problem hiding this comment.
Thanks @andygrove Last time I tried something like this I got an error because the BinaryOperator implementation didn't support
Maybe it is worth starting to collect the necessary parts of this feature under #194
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andy Grove agrove@apache.org
Which issue does this PR close?
Closes ##2229.
Rationale for this change
Attempting to create a query plan from SQL using date + interval expressions was failing with a type-coercion error because no type coercion rule had been implemented for this operation.
What changes are included in this PR?
This PR implements the type coercion rule for date +/ interval, allowing the SQL query to be converted to a valid logical plan. This is sufficient for the use case of using DataFusion as SQL query planner.
A follow-on issue has been filed for implementing support for this expression in the physical planner:
Are there any user-facing changes?
No
No