Move identifer case tests to sql_integ, add negative cases, Debug for DataFrame
#2243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alamb
commented
Apr 15, 2022
| fn fmt(&self, f: &mut std::fmt::Formatter<'_>) -> std::fmt::Result { | ||
| f.debug_struct("SessionState") | ||
| .field("session_id", &self.session_id) | ||
| // TODO should we print out more? |
There was a problem hiding this comment.
There are a lot of other fields on SessionState -- I wasn't sure the value of printing them, so I left it as a future todo
| @@ -3322,173 +3334,6 @@ mod tests { | |||
| Ok(()) | |||
| } | |||
|
|
|||
| #[tokio::test] | |||
There was a problem hiding this comment.
Moved out of context.rs and into datafusion/core/tests/sql/idenfifers.rs without change
| } | ||
|
|
||
| #[tokio::test] | ||
| async fn case_insensitive_in_sql_errors() { |
There was a problem hiding this comment.
This is a new test added in this PR, based on the one from @ReggieFan on #2211 to make it clear this is expected behavior
andygrove
approved these changes
Apr 15, 2022
yjshen
approved these changes
Apr 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2227
Rationale for this change
Basically so that it is clear what types of identifier comparisons are meant to work
Also, Re cleaning up tests #743
What changes are included in this PR?
Debugimpls, so I can useunwrap_err()Are there any user-facing changes?
Debug impl for
DataFameandSessionContext