Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for date32 and date64 in sort merge join #2336

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

hntd187
Copy link
Contributor

@hntd187 hntd187 commented Apr 25, 2022

Which issue does this PR close?

Closes #2314 .

Rationale for this change

It didn't allow this, now it does.

What changes are included in this PR?

Ability to join on date32 and date64

Are there any user-facing changes?

Yes, new functionality

@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Apr 25, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you @hntd187

cc @yjshen @richox

@andygrove andygrove merged commit 036a132 into apache:master Apr 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date32/Date64 as join keys for merge join
3 participants