Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Improve documentation for DFSchema join and merge functions #2367

Merged
merged 1 commit into from
Apr 28, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Apr 28, 2022

Which issue does this PR close?

None

Rationale for this change

Improve documentation to clarify the differences between duplicate field handling between DFSchema::join and DFSchema::merge.

What changes are included in this PR?

Improve documentation

Are there any user-facing changes?

Better docs!

@andygrove andygrove added the documentation Improvements or additions to documentation label Apr 28, 2022
@andygrove andygrove self-assigned this Apr 28, 2022
@andygrove andygrove changed the title Improve documentation for DFSchema combine and merge functions minor: Improve documentation for DFSchema combine and merge functions Apr 28, 2022
@github-actions github-actions bot added the datafusion Changes in the datafusion crate label Apr 28, 2022
@andygrove andygrove changed the title minor: Improve documentation for DFSchema combine and merge functions minor: Improve documentation for DFSchema join and merge functions Apr 28, 2022
@alamb
Copy link
Contributor

alamb commented Apr 28, 2022

Thanks @andygrove !

@alamb alamb merged commit ef49d28 into apache:master Apr 28, 2022
@andygrove andygrove deleted the dfschema-docs branch April 28, 2022 19:48
comphead pushed a commit to comphead/arrow-datafusion that referenced this pull request Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
datafusion Changes in the datafusion crate documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants