Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make datafusion-proto match exhaustive #2567

Merged
merged 1 commit into from
May 18, 2022
Merged

Make datafusion-proto match exhaustive #2567

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion datafusion/proto/src/to_proto.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -713,7 +713,15 @@ impl TryFrom<&Expr> for protobuf::LogicalExprNode {
Expr::Wildcard => Self {
expr_type: Some(ExprType::Wildcard(true)),
},
_ => unimplemented!(),
Expr::ScalarSubquery(_) | Expr::InSubquery { .. } | Expr::Exists { .. } => {
// we would need to add logical plan operators to datafusion.proto to support this
// see discussion in https://github.com/apache/arrow-datafusion/issues/2565
unimplemented!("subquery expressions are not supported yet")
}
Expr::QualifiedWildcard { .. }
| Expr::GetIndexedField { .. }
| Expr::TryCast { .. }
| Expr::GroupingSet(_) => unimplemented!(),
};

Ok(expr_node)
Expand Down