Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Ballista CI check #2684

Merged
merged 2 commits into from
Jun 2, 2022
Merged

Conversation

andygrove
Copy link
Member

Which issue does this PR close?

Closes #2679

Rationale for this change

See #2679

What changes are included in this PR?

  • Remove Ballista CI check
  • Update PR template

Are there any user-facing changes?

No

Does this PR break compatibility with Ballista?

We will never know

@andygrove andygrove self-assigned this Jun 2, 2022
@github-actions github-actions bot added the development-process Related to development process of DataFusion label Jun 2, 2022
@andygrove andygrove requested review from alamb and tustvold June 2, 2022 19:37
@codecov-commenter
Copy link

Codecov Report

Merging #2684 (4998667) into master (49e072a) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #2684      +/-   ##
==========================================
+ Coverage   84.63%   84.69%   +0.06%     
==========================================
  Files         267      267              
  Lines       46867    47004     +137     
==========================================
+ Hits        39665    39811     +146     
+ Misses       7202     7193       -9     
Impacted Files Coverage Δ
...afusion/core/src/datasource/file_format/parquet.rs 87.32% <0.00%> (-1.24%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
datafusion/common/src/scalar.rs 74.94% <0.00%> (-0.24%) ⬇️
...sion/core/src/physical_plan/file_format/parquet.rs 95.21% <0.00%> (-0.02%) ⬇️
datafusion/core/tests/parquet_pruning.rs 98.36% <0.00%> (-0.01%) ⬇️
datafusion/core/tests/sql/parquet.rs 100.00% <0.00%> (ø)
datafusion/expr/src/utils.rs 91.86% <0.00%> (+0.07%) ⬆️
datafusion/sql/src/planner.rs 81.60% <0.00%> (+0.13%) ⬆️
datafusion/core/src/optimizer/filter_push_down.rs 98.14% <0.00%> (+0.58%) ⬆️
datafusion/expr/src/logical_plan/plan.rs 68.15% <0.00%> (+0.96%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e072a...4998667. Read the comment docs.

@andygrove andygrove merged commit 2e129aa into apache:master Jun 2, 2022
@andygrove andygrove deleted the remove-ballista-ci-check branch June 2, 2022 21:29
@alamb
Copy link
Contributor

alamb commented Jun 3, 2022

Thank you @andygrove and @tustvold

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
development-process Related to development process of DataFusion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: remove automated ballista CI checks from DataFusion
4 participants