Rewrite subexpressions of InSubquery in rewrite_expression #2765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
logical-expr
Codecov Report
@@ Coverage Diff @@
## master #2765 +/- ##
=======================================
Coverage 84.95% 84.96%
=======================================
Files 271 271
Lines 48053 48071 +18
=======================================
+ Hits 40824 40842 +18
Misses 7229 7229
Continue to review full report at Codecov.
|
andygrove
approved these changes
Jun 22, 2022
alamb
approved these changes
Jun 22, 2022
| \n TableScan: test projection=None"; | ||
| assert_eq!(format!("{:?}", plan), expected_before); | ||
|
|
||
| // rewrite filter col b to test.a |
Thanks, going to see if I can do this ^ as well, but that can be a separate PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #2736.
Rationale for this change
What changes are included in this PR?
Looking at the expressions mentioned in #2725, I think the only one that needs fixing is
Expr::InSubquery.ExistsandScalarSubqueryboth have subqueries but not subexpressions, and it looks like subqueries are currently treated as completely separate plans for the purposes of optimisation. I'm new to working on query engines (and rust, for that matter!) though so may be misinterpreting this.I've modified
rewrite_expressionsoInSubqueryexprs use the subexpression passed inexpressionsrather than just returning a clone, and added a pushdown test with anInSubquerypredicate which uses an aliased column.Additionally, I noticed while I was creating the test case that
InSubqueryfilters were not being pushed down at all. This was because the subexpressions ofInSubquerywere not being visited byExpressionVisitor, so the column inInSubquerypredicates was not found. Fixed with a simple modification toexpr_visitor.rs. The test case I added covers this as well.Are there any user-facing changes?