fix: correctly calculate join output schema nullability #2803
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #2778
Rationale for this change
apache/arrow-rs#1888 in arrow added validation to
RecordBatch
if the schema's declared nullability is different than its actual nullability.This caught that the output schema calculation for joins is incorrect -- specifically, LEFT/RIGHT/FULL joins can introduce nulls even if the input schema is not nullable.
For example, given the following non-null input:
This query:
Produces a null on
b
(though a is non nullable ifa
is non nullable in the input) and thusb
must be marked nullableWhat changes are included in this PR?
NULL
s introduced in joins in output schema calculationAre there any user-facing changes?
I don't think so (except more correct null schema marking)