Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make cargo clippy happy in nigtly #2860

Merged
merged 1 commit into from
Jul 9, 2022

Conversation

xudong963
Copy link
Member

Make Cargo Clippy happy in nightly mode, making code more elegant

@xudong963 xudong963 requested review from andygrove and alamb July 9, 2022 10:32
@github-actions github-actions bot added core Core DataFusion crate optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner labels Jul 9, 2022
Copy link
Contributor

@Dandandan Dandandan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xudong963 !

@codecov-commenter
Copy link

Codecov Report

Merging #2860 (ccd37b6) into master (a2da720) will increase coverage by 0.00%.
The diff coverage is 63.88%.

@@           Coverage Diff           @@
##           master    #2860   +/-   ##
=======================================
  Coverage   85.24%   85.25%           
=======================================
  Files         275      275           
  Lines       49002    49001    -1     
=======================================
+ Hits        41773    41775    +2     
+ Misses       7229     7226    -3     
Impacted Files Coverage Δ
datafusion/sql/src/utils.rs 51.95% <45.45%> (+0.40%) ⬆️
datafusion/core/src/execution/memory_manager.rs 69.95% <50.00%> (-0.31%) ⬇️
datafusion/core/src/datasource/mod.rs 93.93% <100.00%> (ø)
...e/src/physical_optimizer/hash_build_probe_order.rs 89.04% <100.00%> (ø)
datafusion/core/src/physical_plan/sorts/sort.rs 93.09% <100.00%> (ø)
...atafusion/optimizer/src/subquery_filter_to_join.rs 93.90% <100.00%> (ø)
datafusion/physical-expr/src/expressions/case.rs 92.75% <100.00%> (ø)
datafusion/expr/src/logical_plan/plan.rs 74.50% <0.00%> (+0.19%) ⬆️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a2da720...ccd37b6. Read the comment docs.

@xudong963 xudong963 merged commit 364c9cc into apache:master Jul 9, 2022
@xudong963 xudong963 deleted the fix_clippy branch July 9, 2022 11:11
@alamb
Copy link
Contributor

alamb commented Jul 9, 2022

Thanks @xudong963

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate optimizer Optimizer rules physical-expr Physical Expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants