-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add baseline_metrics for FileStream to record metrics like elapsed ti… #2965
Conversation
…me, record output, etc (#63)
Codecov Report
@@ Coverage Diff @@
## master #2965 +/- ##
==========================================
+ Coverage 85.43% 85.65% +0.22%
==========================================
Files 275 279 +4
Lines 49839 51093 +1254
==========================================
+ Hits 42578 43766 +1188
- Misses 7261 7327 +66
Help us with your feedback. Take ten seconds to tell us how you rate us. |
@alamb PTAL 😊 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good to me
@@ -24,17 +24,23 @@ use crate::physical_plan::{ | |||
use arrow::datatypes::SchemaRef; | |||
|
|||
use crate::execution::context::TaskContext; | |||
#[cfg(feature = "avro")] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this whole file #[cfg(feature = "avro")]
?
In other words, would this work?
#[cfg(feature = "avro")] |
use std::any::Any; | ||
use std::sync::Arc; | ||
|
||
use super::FileScanConfig; | ||
|
||
/// Execution plan for scanning Avro data source | ||
#[derive(Debug, Clone)] | ||
#[allow(dead_code)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure why this is needed
Thanks @Ted-Jiang |
Benchmark runs are scheduled for baseline = e47c4eb and contender = 16f8934. 16f8934 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
…me, record output, etc (#63)
Which issue does this PR close?
Closes #2961
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?