Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add baseline_metrics for FileStream to record metrics like elapsed ti… #2965

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

Ted-Jiang
Copy link
Member

…me, record output, etc (#63)

Which issue does this PR close?

Closes #2961

Rationale for this change

What changes are included in this PR?

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Jul 26, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2965 (585834d) into master (834924f) will increase coverage by 0.22%.
The diff coverage is 95.45%.

@@            Coverage Diff             @@
##           master    #2965      +/-   ##
==========================================
+ Coverage   85.43%   85.65%   +0.22%     
==========================================
  Files         275      279       +4     
  Lines       49839    51093    +1254     
==========================================
+ Hits        42578    43766    +1188     
- Misses       7261     7327      +66     
Impacted Files Coverage Δ
...afusion/core/src/physical_plan/file_format/avro.rs 0.00% <0.00%> (ø)
...tafusion/core/src/physical_plan/file_format/csv.rs 94.47% <100.00%> (+0.10%) ⬆️
.../core/src/physical_plan/file_format/file_stream.rs 90.47% <100.00%> (+0.57%) ⬆️
...afusion/core/src/physical_plan/file_format/json.rs 93.93% <100.00%> (+0.12%) ⬆️
...sion/core/src/physical_plan/file_format/parquet.rs 95.02% <100.00%> (+0.01%) ⬆️
datafusion/optimizer/src/test/mod.rs 94.23% <0.00%> (-5.77%) ⬇️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/optimizer/src/reduce_outer_join.rs 98.79% <0.00%> (-0.61%) ⬇️
datafusion/core/tests/sql/mod.rs 98.26% <0.00%> (-0.56%) ⬇️
datafusion/core/src/physical_plan/metrics/value.rs 86.93% <0.00%> (-0.51%) ⬇️
... and 14 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Ted-Jiang
Copy link
Member Author

@alamb PTAL 😊

Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@@ -24,17 +24,23 @@ use crate::physical_plan::{
use arrow::datatypes::SchemaRef;

use crate::execution::context::TaskContext;
#[cfg(feature = "avro")]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this whole file #[cfg(feature = "avro")] ?

In other words, would this work?

Suggested change
#[cfg(feature = "avro")]

use std::any::Any;
use std::sync::Arc;

use super::FileScanConfig;

/// Execution plan for scanning Avro data source
#[derive(Debug, Clone)]
#[allow(dead_code)]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this is needed

@alamb
Copy link
Contributor

alamb commented Jul 27, 2022

Thanks @Ted-Jiang

@alamb alamb merged commit 16f8934 into apache:master Jul 27, 2022
@ursabot
Copy link

ursabot commented Jul 27, 2022

Benchmark runs are scheduled for baseline = e47c4eb and contender = 16f8934. 16f8934 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add baseline_metrics for FileStream to record metrics like elapsed time, record output, etc
5 participants