Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PR template by commenting out instructions #315

Merged
merged 2 commits into from
May 11, 2021
Merged

Update PR template by commenting out instructions #315

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b975258
Update PR template by commenting out instructions
alamb May 10, 2021
2060dfe
Apply suggestions from code review
alamb May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/pull_request_template.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,25 @@
# Which issue does this PR close?

<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->

Closes #.

# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->

# What changes are included in this PR?

<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->

# Are there any user-facing changes?

<--
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alamb these lines need to be commented out separately

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry @nevi-me -- that is what I get from trying to rush this in. Thank you for the help

alamb marked this conversation as resolved.
Show resolved Hide resolved
If there are user-facing changes then we may require documentation to be updated before approving the PR.
alamb marked this conversation as resolved.
Show resolved Hide resolved

If there are any breaking changes to public APIs, please add the `breaking change` label.
alamb marked this conversation as resolved.
Show resolved Hide resolved
-->