Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[sqlparser-0.21] Changes to planning for SHOW TABLES #3193

Merged
merged 1 commit into from
Aug 18, 2022

Conversation

andygrove
Copy link
Member

@andygrove andygrove commented Aug 18, 2022

Which issue does this PR close?

Part of #3192

Note that this is targeting the sqlparser-0.21 branch.

Rationale for this change

sqlparser made some changes to SHOW TABLE in apache/datafusion-sqlparser-rs#563, and we need to make corresponding changes.

What changes are included in this PR?

sqlparser made some changes to SHOW TABLE and we need to make corresponding changes.

Are there any user-facing changes?

No

@andygrove andygrove changed the base branch from master to sqlparser-0.21 August 18, 2022 17:00
@github-actions github-actions bot added core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner labels Aug 18, 2022
@andygrove andygrove changed the title Changes to planning for SHOW TABLES due to changes in sqlparser [sqlparser-0.21] Changes to planning for SHOW TABLES Aug 18, 2022
@andygrove
Copy link
Member Author

@alamb This is the first sqlparser PR that needs merging to the feature branch

@andygrove andygrove requested a review from tustvold August 18, 2022 18:16
@andygrove andygrove assigned Dandandan and unassigned Dandandan Aug 18, 2022
Copy link
Contributor

@alamb alamb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alamb alamb merged commit 8801986 into apache:sqlparser-0.21 Aug 18, 2022
alamb pushed a commit that referenced this pull request Aug 19, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (#3193)

* Update planning for LIKE due to changes in sqlparser (#3194)

* rename array function to make_array (#3199)

* [sqlparser-0.21] Update trimExpr members during planning (#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (#3202)

Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)

* Update planning for LIKE due to changes in sqlparser (apache#3194)

* rename array function to make_array (apache#3199)

* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (apache#3202)

Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
MazterQyou pushed a commit to cube-js/arrow-datafusion that referenced this pull request Dec 1, 2022
* Changes to planning for SHOW TABLES due to changes in sqlparser (apache#3193)

* Update planning for LIKE due to changes in sqlparser (apache#3194)

* rename array function to make_array (apache#3199)

* [sqlparser-0.21] Update trimExpr members during planning (apache#3181)

* Update sqlparser version to use main from git

* Update SqlExpr::Trim struct to match latest sqlparser changes

* use sqlparser 0.21 (apache#3202)

Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
@andygrove andygrove deleted the sqlparser-show-tables branch January 27, 2023 18:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate logical-expr Logical plan and expressions sql SQL Planner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants