Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] fix bench aggregate_query_sql meta #3218

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

Ted-Jiang
Copy link
Member

Which issue does this PR close?

related #3217

Rationale for this change

when i run cargo bench --bench aggregate_query_sql

got

thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: 

InvalidArgumentError("Column 'f64' is declared as non-nullable but contains null values")', datafusion/core/benches/data_utils/mod.rs:140:6

https://github.com/apache/arrow-datafusion/blob/fecc5ac4360c05db934cef38e8bde4fb669f01d6/datafusion/core/benches/data_utils/mod.rs#L120

then call

https://github.com/apache/arrow-datafusion/blob/fecc5ac4360c05db934cef38e8bde4fb669f01d6/datafusion/core/benches/data_utils/mod.rs#L73-L86

but the schema is none-nullable 🤔

What changes are included in this PR?

Are there any user-facing changes?

@Ted-Jiang
Copy link
Member Author

@alamb PTAL😊

@github-actions github-actions bot added the core Core DataFusion crate label Aug 22, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #3218 (fecc5ac) into master (4838564) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #3218   +/-   ##
=======================================
  Coverage   85.84%   85.84%           
=======================================
  Files         291      291           
  Lines       52909    52909           
=======================================
+ Hits        45419    45420    +1     
+ Misses       7490     7489    -1     
Impacted Files Coverage Δ
datafusion/expr/src/logical_plan/plan.rs 78.00% <0.00%> (+0.17%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Ted-Jiang

@andygrove andygrove merged commit f2313ae into apache:master Aug 22, 2022
@ursabot
Copy link

ursabot commented Aug 22, 2022

Benchmark runs are scheduled for baseline = 1f67876 and contender = f2313ae. f2313ae is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants