Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CREATE VIEW should return empty dataframe #3237

Merged
merged 2 commits into from
Aug 24, 2022

Conversation

kmitchener
Copy link
Contributor

Which issue does this PR close?

Closes #3236 .

Rationale for this change

Per issue -- create view should just create the view.

What changes are included in this PR?

Are there any user-facing changes?

yes, CREATE VIEW will no longer return the results of the given SQL. It will return an empty dataframe upon success.

@github-actions github-actions bot added the core Core DataFusion crate label Aug 23, 2022
@kmitchener kmitchener changed the title create view return empty dataframe CREATE VIEW should return empty dataframe Aug 23, 2022
@andygrove
Copy link
Member

Could you add a test?

@codecov-commenter
Copy link

Codecov Report

Merging #3237 (ac7c957) into master (74872a3) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3237      +/-   ##
==========================================
+ Coverage   85.81%   85.83%   +0.01%     
==========================================
  Files         292      293       +1     
  Lines       53117    53170      +53     
==========================================
+ Hits        45585    45638      +53     
  Misses       7532     7532              
Impacted Files Coverage Δ
datafusion/core/src/execution/context.rs 78.26% <100.00%> (+0.05%) ⬆️
datafusion/optimizer/tests/integration-test.rs 84.00% <0.00%> (ø)
datafusion/expr/src/logical_plan/plan.rs 78.55% <0.00%> (+0.55%) ⬆️
datafusion/expr/src/window_frame.rs 93.27% <0.00%> (+0.84%) ⬆️
datafusion/expr/src/utils.rs 91.10% <0.00%> (+1.07%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kmitchener
Copy link
Contributor Author

Could you add a test?

Added

@andygrove andygrove merged commit aa6a34b into apache:master Aug 24, 2022
@ursabot
Copy link

ursabot commented Aug 24, 2022

Benchmark runs are scheduled for baseline = c574269 and contender = aa6a34b. aa6a34b is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kmitchener kmitchener deleted the create-view-empty-df branch August 24, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE VIEW should return an empty dataframe on success
5 participants