Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix no schema when CSV is only header #3272

Merged
merged 1 commit into from
Aug 26, 2022

Conversation

comphead
Copy link
Contributor

@comphead comphead commented Aug 26, 2022

Which issue does this PR close?

Closes #3263 .

Rationale for this change

What changes are included in this PR?

Fix no schema when CSV is only header

Are there any user-facing changes?

@github-actions github-actions bot added the core Core DataFusion crate label Aug 26, 2022
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @comphead

@codecov-commenter
Copy link

Codecov Report

Merging #3272 (2add83d) into master (92110dd) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #3272      +/-   ##
==========================================
- Coverage   85.89%   85.89%   -0.01%     
==========================================
  Files         294      294              
  Lines       53373    53400      +27     
==========================================
+ Hits        45845    45868      +23     
- Misses       7528     7532       +4     
Impacted Files Coverage Δ
datafusion/core/src/datasource/file_format/csv.rs 98.91% <100.00%> (ø)
datafusion/core/tests/sql/create_drop.rs 95.74% <100.00%> (+0.45%) ⬆️
datafusion/expr/src/window_frame.rs 92.43% <0.00%> (-0.85%) ⬇️
datafusion/expr/src/logical_plan/plan.rs 78.21% <0.00%> (-0.52%) ⬇️
...fusion/optimizer/src/pre_cast_lit_in_comparison.rs 85.60% <0.00%> (+2.27%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andygrove andygrove merged commit 90a0e7c into apache:master Aug 26, 2022
@ursabot
Copy link

ursabot commented Aug 26, 2022

Benchmark runs are scheduled for baseline = 5ee52d0 and contender = 90a0e7c. 90a0e7c is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@comphead comphead deleted the csv_header_nocols branch September 8, 2022 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE EXTERNAL TABLE from CSV creates a table with no columns if there is just a header row
4 participants