Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return empty dataframe on create table, remove a duplicate optimize call #3361

Merged
merged 1 commit into from
Sep 5, 2022

Conversation

kmitchener
Copy link
Contributor

update docs

Which issue does this PR close?

Closes #3265 .

Rationale for this change

What changes are included in this PR?

  • per issue, successful create table returns an empty dataframe instead of a full select of what's in the table
  • removed an extra optimize() call during creation
  • updated docs

Are there any user-facing changes?

Slight. When creating a table in datafusion-cli, it will no longer return the contents of the table created.

@github-actions github-actions bot added the core Core DataFusion crate label Sep 5, 2022
Copy link
Member

@andygrove andygrove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @kmitchener

@Dandandan Dandandan merged commit ede82fb into apache:master Sep 5, 2022
@Dandandan
Copy link
Contributor

Thanks @kmitchener

@ursabot
Copy link

ursabot commented Sep 5, 2022

Benchmark runs are scheduled for baseline = 4c948a3 and contender = ede82fb. ede82fb is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ec2-t3-xlarge-us-east-2] ec2-t3-xlarge-us-east-2
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on test-mac-arm] test-mac-arm
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-i9-9960x] ursa-i9-9960x
[Skipped ⚠️ Benchmarking of arrow-datafusion-commits is not supported on ursa-thinkcentre-m75q] ursa-thinkcentre-m75q
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java

@kmitchener kmitchener deleted the 3265-create-table-empty-df branch September 6, 2022 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Core DataFusion crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CREATE TABLE should return empty DataFrame
4 participants