-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace From trait with TryFrom trait for datafusion-proto crate #3401 #3429
Conversation
@andygrove this is related to your comment #3365 (comment) Please review |
Codecov Report
@@ Coverage Diff @@
## master #3429 +/- ##
==========================================
+ Coverage 85.51% 85.61% +0.10%
==========================================
Files 296 296
Lines 54303 54482 +179
==========================================
+ Hits 46436 46645 +209
+ Misses 7867 7837 -30
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me -- thanks @comphead
@@ -719,7 +719,7 @@ impl AsLogicalPlan for LogicalPlanNode { | |||
}) | |||
} | |||
}; | |||
let schema: protobuf::Schema = schema.as_ref().into(); | |||
let schema: protobuf::Schema = schema.as_ref().try_into()?; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @comphead!
Benchmark runs are scheduled for baseline = b247204 and contender = 24f2770. 24f2770 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3401 .
Rationale for this change
Replacing From with TryFrom will help with error handling
What changes are included in this PR?
Replace From trait with TryFrom trait for datafusion-proto crate #3401
Are there any user-facing changes?
No