-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce dependencies of datafusion-sql
crate
#3566
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
+ Coverage 85.81% 85.91% +0.10%
==========================================
Files 300 301 +1
Lines 55548 56218 +670
==========================================
+ Hits 47666 48301 +635
- Misses 7882 7917 +35
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks @mbrobbel
ordered-float = "3.0" | ||
parquet = { version = "23.0.0", features = ["arrow"], optional = true } | ||
parquet = { version = "23.0.0", default-features = false, optional = true } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the only reason for these dependencies is deriving From conversions for ArrowError, perhaps we could/should just remove them. This is what I have been doing when splitting apart arrow-rs - see apache/arrow-rs#2711.
In general the error handling is a little bit unfortunate, so perhaps this will all get addressed eventually by apache/arrow-rs#2725
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes absolutely. I was planning on revisiting this after the arrow-rs split.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just as an FYI, mixing feature combinations within a workspace can make for a pretty poor development experience as switching between targets causes things to get rebuilt. Hopefully as we split apart arrow-rs apache/arrow-rs#2594 our reliance on feature flags will reduce.
See https://docs.rs/cargo-hakari/latest/cargo_hakari/about/index.html#what-are-workspace-hack-crates for more information.
Thanks @mbrobbel |
Benchmark runs are scheduled for baseline = cec6395 and contender = 31acc83. 31acc83 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
This doesn't close, but contributes to the changes being worked on in #1750.
Rationale for this change
By disabling features and removing unused dependencies the build time of those crates is reduced.
What changes are included in this PR?
This PR removes some unused direct dependencies of the
sql
,common
andexpr
crates, and disables unused features.Are there any user-facing changes?
No