-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add timestamptz #3660
add timestamptz #3660
Conversation
@avantgardnerio @alamb @liukun4515
1 and 2 were done. this pr is to enable 3 |
note that there're some functions don't work with timestamptz due to mismatch function signatures ❯ select extract(hour from now());
Plan("Coercion from [Utf8, Timestamp(Nanosecond, Some(\"UTC\"))] to the signature OneOf([Exact([Utf8, Date32]), Exact([Utf8, Date64]), Exact([Utf8, Timestamp(Second, None)]), Exact([Utf8, Timestamp(Microsecond, None)]), Exact([Utf8, Timestamp(Millisecond, None)]), Exact([Utf8, Timestamp(Nanosecond, None)])]) failed.") i'd like to add these in separate pr |
Codecov Report
@@ Coverage Diff @@
## master #3660 +/- ##
=======================================
Coverage 86.01% 86.02%
=======================================
Files 300 300
Lines 56583 56595 +12
=======================================
+ Hits 48672 48684 +12
Misses 7911 7911
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -- thank you @waitingkuo
Benchmark runs are scheduled for baseline = 65a5c6b and contender = bfc5ff0. bfc5ff0 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Closes #3659
Rationale for this change
Fix the timezone as
UTC
for now before we figure out how to deal with non-utc timezonecasting between timestamp and timestamptz has no ambiguity under this situation
What changes are included in this PR?
Are there any user-facing changes?