Support Dictionary in InListExpr #4070
Conversation
github-actions
bot
added
core
| @@ -440,7 +533,7 @@ async fn in_set_string_dictionaries() -> Result<()> { | |||
| let ctx = SessionContext::new(); | |||
| ctx.register_batch("test", batch)?; | |||
|
|
|||
| let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazz')"; | |||
| let sql = "SELECT * FROM test WHERE c1 IN ('foo', 'Bar', 'fazzz')"; | |||
There was a problem hiding this comment.
This test was previously ignored, as it failed, and was actually wrong 😆
| ]; | ||
| assert_batches_eq!(expected, &actual); | ||
| Ok(()) | ||
| } |
tustvold
force-pushed
the
in-list-dictionary
branch
from
9973b03 to
f488212
Compare
|
Benchmark runs are scheduled for baseline = 8741372 and contender = 61429f8. 61429f8 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
* Support dictionary in InList (apache#3936) * Update datafusion-cli
Draft as builds on #4057Which issue does this PR close?
Closes #3936
Rationale for this change
What changes are included in this PR?
Are there any user-facing changes?